fix: remove warning for groups without label#786
Closed
jkuester wants to merge 5 commits intoXLSForm:masterfrom
Closed
fix: remove warning for groups without label#786jkuester wants to merge 5 commits intoXLSForm:masterfrom
jkuester wants to merge 5 commits intoXLSForm:masterfrom
Conversation
# Conflicts: # pyxform/xls2json.py
This was referenced Nov 19, 2025
Contributor
|
Thanks, @jkuester! This still feels like the right move to me. @lindsay-stevens could you please take a look when you get a chance? |
# Conflicts: # tests/test_fieldlist_labels.py
Contributor
|
Thanks again for bringing this up, @jkuester! We had a few other priorities to tend to and @lindsay-stevens picked this back up with a couple more simplifications at #801. It should be merged in the next few days and released in Feb unless you need it sooner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #785
This might be premature as I see
#785is still labeled with "needs discussion". 😅 However, as the code was already fresh in my mind, I figured I would raise a PR to provide some additional impetus to the discussion as well as a concrete proposal to discuss.Why is this the best possible solution? Were any other approaches considered?
The rational for this change is covered in detail on the forum thread, but the TLDR is:
field-listappearance (but that appearance cannot be combined with any other appearance or the warning will re-appear). However, semantically it is meaningless to nestfield-listgroups. So, this workaround is not appropriate for all cases.What are the regression risks?
The main "risk" I see here would be that users could unintentionally add groups with no label/hint (because they did not see any warning about it). Technically I guess this would not be a "regression" in terms of form functionality, though.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
The ODK docs already note:
I do not think these changes require any specific modifications to the xlsform docs.
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code