Skip to content

refactor: lowercase channel factory across subworkflows + workflows#504

Merged
madeline-scyphers merged 2 commits into
WrightonLabCSU:devfrom
tpall:channel-cleanup
May 14, 2026
Merged

refactor: lowercase channel factory across subworkflows + workflows#504
madeline-scyphers merged 2 commits into
WrightonLabCSU:devfrom
tpall:channel-cleanup

Conversation

@tpall
Copy link
Copy Markdown

@tpall tpall commented May 8, 2026

Summary

Pure cosmetic refactor: switch from the Channel class qualifier to the lowercase channel factory function across all subworkflows + workflows. Both forms work in DSL2; lowercase channel is the documented default and the more common style in modern nf-core pipelines.

This was one of the changes bundled into the now-closed #472 per @madeline-scyphers' note ("thanks for some of the other QoL updates like updating some of the syntax to DSL2 (Channel -> channel, etc.)"). Splitting it out into its own PR per the maintainer-friendly path agreed when refiling #503.

What changed

21e5cb8f refactor: lowercase `channel` factory across subworkflows + workflows

+42 / -42 lines, 7 files, mechanical Channel.Xchannel.X substitution wherever a channel factory is used:

subworkflows/local/call.nf
subworkflows/local/collect_rna.nf
subworkflows/local/db_search.nf
subworkflows/local/merge.nf
subworkflows/local/qc.nf
subworkflows/local/utils_nfcore_dram_pipeline/main.nf
workflows/dram.nf

Test plan

  • No semantic change — channel and Channel resolve to the same Nextflow factory in DSL2.
  • git diff --stat shows equal +/- counts (one-for-one substitution).
  • CI / integration test on dev if you'd like a smoke run before merge.

🤖 Generated with Claude Code

DSL2 prefers the lowercase `channel` factory function over the
`Channel` class qualifier — both work but the lowercase form is the
documented default and is a one-character net win on every line that
constructs a channel. Pure cosmetic refactor, no behaviour change.

Touches all sites currently using `Channel.empty`, `Channel.fromPath`,
etc. across:

  subworkflows/local/{call,collect_rna,db_search,merge,qc,
                      utils_nfcore_dram_pipeline}.nf
  workflows/dram.nf
@madeline-scyphers madeline-scyphers merged commit cca89cd into WrightonLabCSU:dev May 14, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from To Sort to Done in DRAM May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants