Introduce LifecycleModuleV2; Lifecycle-only, no api, components, or events#179
Draft
maxwellpeterson-wf wants to merge 1 commit intomasterfrom
Draft
Introduce LifecycleModuleV2; Lifecycle-only, no api, components, or events#179maxwellpeterson-wf wants to merge 1 commit intomasterfrom
maxwellpeterson-wf wants to merge 1 commit intomasterfrom
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| /// Intended to be extended by most base module classes in order to provide a | ||
| /// unified lifecycle API. | ||
| abstract class LifecycleModule extends SimpleModule with Disposable { | ||
| abstract class _LifecycleModule<T extends _LifecycleModule<T>> with Disposable { |
Member
Author
There was a problem hiding this comment.
Note that SimpleModule contains api, components, and events - the properties I am attempting to compose out of the new LifecycleModuleV2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.