Skip to content

chore: Update Indicator components#3738

Merged
alanbsmith merged 32 commits intoWorkday:prerelease/majorfrom
josh-bagwell:chore/update-indicators-26-02
Feb 12, 2026
Merged

chore: Update Indicator components#3738
alanbsmith merged 32 commits intoWorkday:prerelease/majorfrom
josh-bagwell:chore/update-indicators-26-02

Conversation

@josh-bagwell
Copy link
Copy Markdown
Contributor

@josh-bagwell josh-bagwell commented Feb 2, 2026

Summary

This updates:
StatusIndicator (Preview)
Avatar
Badge
Banner
InformationHighlight
Pill
Skeleton

Fixes: #3589

Release Category

Components

Release Note

Updates Indicators to use v4 tokens with fallbacks of v3 tokens.


Checklist

Where Should the Reviewer Start?

/modules/preview-react/status-indicator
/modules/react/avatar
/modules/react/badge
/modules/react/banner
/modules/react/information-highlight
/modules/react/pill
/modules/react/skeleton

@cypress
Copy link
Copy Markdown

cypress Bot commented Feb 2, 2026

Workday/canvas-kit    Run #10307

Run Properties:  status check passed Passed #10307  •  git commit f6e0199ce0 ℹ️: Merge b6f5ef825a4534d06281f5c367c2d6e0339b184d into 329aa169eef0af1df44a09d2d09c...
Project Workday/canvas-kit
Branch Review chore/update-indicators-26-02
Run status status check passed Passed #10307
Run duration 02m 30s
Commit git commit f6e0199ce0 ℹ️: Merge b6f5ef825a4534d06281f5c367c2d6e0339b184d into 329aa169eef0af1df44a09d2d09c...
Committer Josh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 15
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 802
View all changes introduced in this branch ↗︎
UI Coverage  19.49%
  Untested elements 1518  
  Tested elements 365  
Accessibility  99.41%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 72  

@josh-bagwell josh-bagwell marked this pull request as ready for review February 10, 2026 23:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Canvas Kit “Indicator” components to use @workday/canvas-tokens-web v4 tokens (with v3 fallbacks), and adds new styling utilities/transform support to enable token-based color mixing for interaction states.

Changes:

  • Bump @workday/canvas-tokens-web from 4.0.24.1.2 across packages.
  • Introduce colorSpace.darken in @workday/canvas-kit-styling and add a corresponding TS transformer (handleColorSpace) for static style extraction.
  • Update multiple indicator components/stories to use v4 tokens (with cssVar(...) fallbacks).

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
package.json Bumps @workday/canvas-tokens-web to 4.1.2 at repo root.
modules/styling/package.json Bumps tokens dependency for styling package.
modules/styling/lib/colorSpace.tsx Adds colorSpace.darken + helper for wrapping CSS vars (currently has correctness issues).
modules/styling/index.ts Exports colorSpace from styling package entrypoint.
modules/styling-transform/package.json Bumps tokens dependency for styling-transform package.
modules/styling-transform/lib/utils/handleColorSpace.ts Adds transformer for colorSpace.darken(...) calls (needs robustness + tests).
modules/styling-transform/lib/styleTransform.ts Registers handleColorSpace in property transform pipeline.
modules/react/status-indicator/stories/examples/Basic.tsx Updates story spacing token usage (introduces unused import).
modules/react/status-indicator/stories/examples/Emphasis.tsx Updates story spacing token usage (introduces unused import).
modules/react/status-indicator/stories/examples/MaxWidth.tsx Updates story spacing token usage (introduces unused import).
modules/react/skeleton/lib/parts/SkeletonText.tsx Updates SkeletonText to v4 tokens with fallbacks; adjusts sizing/spacing.
modules/react/skeleton/lib/parts/SkeletonShape.tsx Updates SkeletonShape tokens with v4+fallbacks.
modules/react/skeleton/lib/parts/SkeletonHeader.tsx Updates SkeletonHeader tokens with v4+fallbacks.
modules/react/pill/lib/PillIconButton.tsx Updates PillIconButton tokens; interaction-state background behavior changes.
modules/react/pill/lib/PillIcon.tsx Updates spacing token usage with v4+fallbacks.
modules/react/pill/lib/PillCount.tsx Updates PillCount tokens; border behavior changed.
modules/react/pill/lib/Pill.tsx Updates Pill tokens; adds colorSpace.darken for hover/active backgrounds.
modules/react/package.json Bumps tokens dependency for main react package.
modules/react/loading-dots/lib/LoadingDots.tsx Updates LoadingDots tokens/defaults with v4+fallbacks.
modules/react/layout/stories/Box.mdx Adds Storybook Meta import usage.
modules/react/information-highlight/lib/parts/Link.tsx Updates text color token usage with v4+fallbacks.
modules/react/information-highlight/lib/parts/Heading.tsx Updates text color + margin reset.
modules/react/information-highlight/lib/parts/Body.tsx Updates text color + spacing token usage with v4+fallbacks.
modules/react/information-highlight/lib/InformationHighlight.tsx Updates layout + variant color tokens with v4+fallbacks.
modules/react/banner/lib/Banner.tsx Updates Banner tokens; adds colorSpace.darken hover behavior.
modules/react/badge/lib/CountBadge.tsx Updates CountBadge tokens with v4+fallbacks.
modules/react/avatar/stories/Avatar.mdx Adds Storybook Meta and updates MDX imports/formatting.
modules/react/avatar/lib/BaseAvatar.tsx Updates Avatar sizes/shapes to v4 tokens and explicit sizes.
modules/preview-react/status-indicator/lib/StatusIndicator.tsx Updates preview StatusIndicator tokens with v4+fallbacks.
modules/preview-react/package.json Bumps tokens dependency for preview-react.
modules/labs-react/package.json Bumps tokens dependency for labs-react.
modules/docs/package.json Bumps tokens dependency for docs package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/styling/lib/colorSpace.tsx Outdated
Comment thread modules/styling/lib/colorSpace.tsx
Comment thread modules/react/pill/lib/Pill.tsx Outdated
Comment thread modules/styling-transform/lib/utils/handleColorSpace.ts
Comment thread modules/react/status-indicator/stories/examples/MaxWidth.tsx
Comment thread modules/styling-transform/lib/utils/handleColorSpace.ts
Comment thread modules/react/status-indicator/stories/examples/Basic.tsx
Comment thread modules/react/banner/lib/Banner.tsx Outdated
Comment thread modules/styling/lib/colorSpace.tsx
Comment thread modules/react/pill/lib/PillIconButton.tsx
Comment thread modules/preview-react/status-indicator/lib/StatusIndicator.tsx Outdated
Comment thread modules/react/banner/lib/Banner.tsx
Comment thread modules/react/information-highlight/lib/parts/Heading.tsx
Comment thread modules/react/avatar/lib/BaseAvatar.tsx
Comment thread modules/react/avatar/lib/BaseAvatar.tsx Outdated
Comment thread modules/react/information-highlight/lib/parts/Heading.tsx Outdated
@mannycarrera4
Copy link
Copy Markdown
Contributor

image Is broken this is for status indicator, can you update the mdx to have `import StatusIndicatorStoriesMeta from './StatusIndicator.stories';`

@mannycarrera4
Copy link
Copy Markdown
Contributor

image Looks like the border radius still needs to be updated for status indicators

Comment thread modules/react/pill/lib/PillCount.tsx Outdated
Comment thread modules/react/pill/lib/PillCount.tsx Outdated
Comment thread modules/react/pill/lib/PillCount.tsx Outdated
Comment thread modules/react/information-highlight/lib/InformationHighlight.tsx Outdated
Comment thread modules/react/pill/lib/Pill.tsx Outdated
Comment thread modules/react/information-highlight/lib/parts/Heading.tsx
Comment thread modules/preview-react/status-indicator/lib/StatusIndicator.tsx Outdated
Comment thread modules/preview-react/status-indicator/lib/StatusIndicator.tsx Outdated
Comment thread modules/react/avatar/lib/BaseAvatar.tsx Outdated
Comment thread modules/preview-react/status-indicator/stories/examples/Overflow.tsx Outdated
Comment thread modules/react/avatar/lib/BaseAvatar.tsx Outdated
Comment thread modules/react/information-highlight/lib/parts/Link.tsx Outdated
Comment thread modules/react/pill/lib/Pill.tsx
@alanbsmith alanbsmith merged commit a71b141 into Workday:prerelease/major Feb 12, 2026
20 checks passed
@alanbsmith alanbsmith mentioned this pull request Feb 25, 2026
10 tasks
@alanbsmith alanbsmith mentioned this pull request Apr 13, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ready for review Code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants