add the ability to create internal queues as quorum type instead of hard-coded classic - #80
Open
Michalis-Apostolou wants to merge 2 commits into
Open
Conversation
…ard-coded classic
ch-asimakopoulos
requested review from
Nikoklis,
ch-asimakopoulos and
iliasbibas
September 14, 2026 08:55
kkyriakidis
reviewed
Sep 14, 2026
| 'delay', | ||
| { | ||
| deadLetterExchange: '', | ||
| deadLetterRoutingKey: 'delay_reply', |
There was a problem hiding this comment.
should this be delay_quorum_reply?
Author
There was a problem hiding this comment.
This value is derived by module's variable delayedQueueNameReply
rabbit-queue/ts/delay-queue.ts
Line 22 in 5119a30
createDelayQueueReply parameter.Amended the test , to also call
createDelayQueueReply with createQueueAsQuorum , so it set the expected queue name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need
We need to upgrade the rmq cluster to version 4+. in this version High Availability (HA) policy with mirror queues has been deprecated and completely removed https://www.rabbitmq.com/docs/3.13/ha . So we need to replace all
classicqueue definitions withquorumProblem
Rabbit-queue creates internal queues to implement scheduled publishing for a message
{prefix}_delay_reply{prefix}_delay_{XXX}Example:

Since the library does not define the type of the queue , the are created to what is default on the virtual host.
If can't/don't want to change the default queue type of the virtual host , you should have the ability to define if these queues should be created as quorum or not.
Solution
By utilizing the option available in the package
defaultQueueTypeon rabbit config, this will passed around during the creating of the queues.In order to avoid conflicts between already created
classicqueues and newly createdquorumqueues , the naming convention changes to{prefix}_delay_quorum_reply{prefix}_delay_quorum_{XXX}