Skip to content

Style: Stop link colours repainting block button labels #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
softglazee wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Style: Stop link colours repainting block button labels #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions wordpress.org/public_html/style/wp4-rtl.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ pre {

pre a { font-weight: normal; }

a {
a:where(:not(.wp-element-button)) {
color: #21759b;
text-decoration: none;
font-weight: normal;
Expand All @@ -57,7 +57,7 @@ strong a {
font-weight: bold;
}

a:visited {
a:visited:where(:not(.wp-element-button)) {
color: #4ca6cf;
}

Expand All @@ -71,7 +71,27 @@ h3 a { font-weight: bold; }

p a:hover { border-bottom: 1px solid #d54e21; }

a:hover { color: #d54e21; }
a:hover:where(:not(.wp-element-button)) { color: #d54e21; }

/*
* Buttons are not body links. The link colours above are more specific than the
* button colours the block theme emits, which is `:root :where( .wp-block-button
* .wp-block-button__link )`, so without the `:not( .wp-element-button )` guards
* they repaint button labels. These rules restore the hover, focus and active
* states from the same button custom properties the wporg parent theme uses, for
* pages that load wp4.css and not the parent theme's button stylesheet.
* See https://meta.trac.wordpress.org/ticket/8418
*/
.wp-block-button__link:hover,
.wp-block-button__link:focus {
color: var( --wp--custom--button--hover--color--text, #fff );
background-color: var( --wp--custom--button--hover--color--background, #213fd4 );
}

.wp-block-button__link:active {
color: var( --wp--custom--button--active--color--text, #fff );
background-color: var( --wp--custom--button--active--color--background, #1e1e1e );
}

h2,
h1.heading {
Expand Down
28 changes: 24 additions & 4 deletions wordpress.org/public_html/style/wp4.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.