Skip to content

59710 wp privacy exports dir #5553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbearne wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

59710 wp privacy exports dir #5553

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f7b31a
test for wp_privacy_exports_url
pbearne Oct 23, 2023
348746b
test for wp_privacy_exports_dir
pbearne Oct 23, 2023
bcf8d6e
Update wpPrivacyExportsDir.php
pbearne Oct 26, 2023
eab491c
Update tests/phpunit/tests/functions/wpPrivacyExportsDir.php
pbearne Jun 26, 2026
c5d25c2
Update tests/phpunit/tests/functions/wpPrivacyExportsDir.php
pbearne Jun 26, 2026
d91ec17
Update tests/phpunit/tests/functions/wpPrivacyExportsDir.php
pbearne Jun 26, 2026
29d8c54
Update tests/phpunit/tests/functions/wpPrivacyExportsDir.php
pbearne Jun 26, 2026
b97868a
Merge branch 'trunk' into 59710_wp_privacy_exports_dir
pbearne Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions tests/phpunit/tests/functions/wpPrivacyExportsDir.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?php
/**
* Tests for the wp_privacy_exports_dir function.
*
* @group functions.php
*
* @covers ::wp_privacy_exports_dir
*/
class Tests_Functions_wpPrivacyExportsDir extends WP_UnitTestCase {

/**
* @ticket 59710
*/
public function test_wp_privacy_exports_dir() {

$this->assertEquals( '/var/www/src/wp-content/uploads/wp-personal-data-exports/', wp_privacy_exports_dir() );
Comment on lines +15 to +16

@mindctrl mindctrl Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deriving the directory at runtime should allow the tests to run in other setups.

Suggested change
$this->assertEquals( '/var/www/src/wp-content/uploads/wp-personal-data-exports/', wp_privacy_exports_dir() );
$upload_dir = wp_upload_dir();
$expected = trailingslashit( $upload_dir['basedir'] ) . 'wp-personal-data-exports/';
$this->assertSame( $expected, wp_privacy_exports_dir() );

}

/**
* @ticket 59710
*/
public function test_wp_privacy_exports_dir_filtered() {

add_filter( 'wp_privacy_exports_dir', array( $this, 'filter_wp_privacy_exports_dir' ) );

$expected_dir = '/wp-personal-data-exports-dir/';
$actual_dir = wp_privacy_exports_dir();
$this->assertEquals( $expected_dir, $actual_dir );

@mindctrl mindctrl Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->assertEquals( $expected_dir, $actual_dir );
$this->assertSame( $expected_dir, $actual_dir );


remove_filter( 'wp_privacy_exports_dir', array( $this, 'filter_wp_privacy_exports_dir' ) );
}

/**
* Filter for test
*
* @param string $dir
*/
public function filter_wp_privacy_exports_dir( $dir ) {

return '/wp-personal-data-exports-dir/';
}
}
Loading