Repository navigation
Conversation
The insecure registration test set the label for its critical result as the default, so a site with safe registration settings listed "Open Registration with privileged default role" under passed tests. The passing result now reads "New users are not given a privileged role", and the critical result sets its own label in sentence case. Its description is wrapped in a paragraph, like the passing description and other Site Health results. Adds the first tests for this check. See #66359.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
WP_Site_Health::get_test_insecure_registration()set the label for its critical result as the default, so a site with safe registration settings listed "Open Registration with privileged default role" under Passed tests, which reads like a warning.<p>, like the passing description and other Site Health results.registrationoption, becauseusers_can_registerfollows it there.Two translatable strings change; 7.2 is in beta, before the RC1 string freeze.
Trac ticket: https://core.trac.wordpress.org/ticket/66359
Testing Instructions
Unit tests:
npm run test:php -- --group 66359. On trunk, the label and markup tests fail; with this PR, all 9 pass on single site and multisite.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Used for: Finding the issue during 7.2-beta1 testing, and drafting the fix, tests and this description. I reviewed the changes and ran the tests.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.