Repository navigation
Tests: Add unit test coverage for wp_is_writable() - #14667
Open
shail-mehta wants to merge 1 commit into
Open
shail-mehta wants to merge 1 commit into
shail-mehta wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues in the focused test-only changes; tests were not executed.
No open issues 🎉
What changed in this PR
Adds dedicated unit coverage for wp_is_writable() under Trac #65819, without changing production code.
Changes:
- Tests writable temporary directories and files.
- Tests that a path with a missing parent returns
false, accounting for Windows behavior.
| File | Description |
|---|---|
| tests/phpunit/tests/functions/wpIsWritable.php | Adds three focused tests for wp_is_writable(). |
Review effort: Balanced
shail-mehta
marked this pull request as ready for review
October 21, 2026 17:54
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Trac ticket: #65819
Adds unit tests for
wp_is_writable()intests/phpunit/tests/functions/wpIsWritable.php.Why
wp_is_writable()has no dedicated unit tests. Adding coverage for this helper fills that gap under #65819.How
New test class covering:
truefalsetrueTest-only; no production code changes.
Testing Instructions
npm run test:php -- --filter Tests_Functions_wpIsWritablenpm run test:php -- --filter Tests_Functions_wpIsWritable -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_Functions_wpIsWritable --order-by=randomnpm run test:php -- --group functionsUse of AI Tools