Repository navigation
Icons: Prevent unregistering core-admin icons (Trac #66344) - #14621
ArkaPrabhaChowdhury wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The admin menu and admin bar depend on the non-public
core-adminicon collection. Unregistering that collection, or one of its icons, currently leaves the corresponding admin UI without icons.Reject those operations with
_doing_it_wrong()and returnfalsebefore changing either registry. The guards live in the registry methods so both direct calls and the public helpers are covered. Onlycore-adminis protected: the publiccorecollection and third-party collections remain removable, including cascading removal of their icons.Regression tests exercise both blocked operations, unchanged SVG output, and successful removal of
coreicons and their collection. The REST icon test fixture now uses temporary registry instances instead of unregistering the protected collection, and restores the original instances afterward.Human verification
On a development installation with
WP_DEBUGandWP_DEBUG_LOGenabled, add this temporary MU plugin:false, andwp_get_icon( 'core-admin/dashboard' )should still return SVG markup.core/plus, thencore. Both calls should returntrue; the public collection should be removed while the admin icons remain visible.These are verification steps for a human reviewer; no completed human review is claimed.
Trac ticket: https://core.trac.wordpress.org/ticket/66344
Use of AI Tools
AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-6
Used for: Ticket analysis, implementation, regression tests, local verification, and PR text. Human review remains pending.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.