Skip to content

Tests: Add unit test coverage for validate_active_plugins() - #14608

Open
huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/validate-active-plugins
Open

huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/validate-active-plugins

Conversation

@huzaifaalmesbah

Copy link
Copy Markdown
Member

Description

Adds tests for validate_active_plugins(), which deactivates active plugins that are missing or invalid when the Plugins screen loads, and for the validate_plugin() errors it reports. The existing tests only check a removed plugin being reported and the empty case.

The tests use a temporary plugin file without a header and the plugins in the test data directory. They cover:

  • an active_plugins option that is not an array (a string or an integer) being reset;
  • valid active plugins being kept;
  • the plugin_invalid, plugin_not_found and no_plugin_header errors with their messages, and the invalid plugins being deactivated silently while the valid one stays active;
  • on multisite, network-active plugins being validated and deactivated for a user who can manage network plugins, and left alone for other users.

Removing or changing each branch of the two functions makes at least one test fail on single site or multisite.

This is a test-only change; no production code is modified.

Testing Instructions

  1. Run the tests on single site:
    npm run test:php -- --filter Tests_Admin_Includes_Plugin_ValidateActivePlugins
  2. Run them on multisite:
    npm run test:php -- --filter Tests_Admin_Includes_Plugin_ValidateActivePlugins -c tests/phpunit/multisite.xml
  3. Run them in random order:
    npm run test:php -- --filter Tests_Admin_Includes_Plugin_ValidateActivePlugins --order-by=random
  4. Run the plugins group:
    npm run test:php -- --group plugins
  5. Run PHPCS on the test file:
    node ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/admin/includes/plugin/validateActivePlugins.php

Trac ticket: https://core.trac.wordpress.org/ticket/65819

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.

@huzaifaalmesbah
huzaifaalmesbah marked this pull request as ready for review October 21, 2026 04:27
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertions match the source, and CI passes. One note about fixture cleanup inline.

parent::set_up();

$dir = WP_PLUGIN_DIR . '/' . self::NO_HEADER_DIR;
$this->assertDirectoryDoesNotExist( $dir, 'The test directory should not exist yet.' );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In core tests, WP_PLUGIN_DIR is tests/phpunit/data/plugins, which is a tracked directory. If a run stops partway, such as on a fatal error or Ctrl+C, tear_down() never runs and this fixture folder stays there. The folder name is fixed, so this assertion fails on the next run. So every test in the class fails here until someone deletes the folder by hand. The leftover also shows up in git status.

Could this helper, or set_up(), remove a leftover folder first? #14600 already does this: its remove_plugin() helper runs in both set_up() and tear_down().

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Added a remove_plugin() helper that runs in both set_up() and tear_down(), in 7d99d5d. I checked it with a leftover folder in place: the old code failed and the new code passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants