Skip to content

Tests: Add unit test coverage for delete_plugins() - #14604

Open
huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/delete-plugins
Open

huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/delete-plugins

Conversation

@huzaifaalmesbah

Copy link
Copy Markdown
Member

Description

Adds tests for delete_plugins(), which deletes plugins from the Plugins screen after running their uninstall routines. The function was only reached through capability and Ajax tests.

The tests create temporary plugins (and translation files) in the test data directories with the direct filesystem method, and remove anything left behind. A plugin that cannot be removed is simulated with a non-empty directory named like a single-file plugin, which a non-recursive delete cannot remove. They cover:

  • false without plugins;
  • a plugin directory being deleted, with delete_plugin and deleted_plugin receiving the plugin and the result;
  • only the file of a single-file plugin being deleted;
  • the plugin's uninstall callback running first;
  • deleted plugins being removed from the available updates, while plugins that could not be removed and other plugins are kept;
  • the plugin's .po, .mo, .l10n.php and .json translation files being removed, while other plugins' translations are kept;
  • the could_not_remove_plugin error naming one or several plugins, with deleted_plugin receiving false, while the other plugins are still deleted.

Removing or changing each branch of the function makes at least one test fail. The request-credentials paths that print a form and exit are left out.

This is a test-only change; no production code is modified.

Testing Instructions

  1. Run the tests on single site:
    npm run test:php -- --filter Tests_Admin_Includes_Plugin_DeletePlugins
  2. Run them on multisite:
    npm run test:php -- --filter Tests_Admin_Includes_Plugin_DeletePlugins -c tests/phpunit/multisite.xml
  3. Run them in random order:
    npm run test:php -- --filter Tests_Admin_Includes_Plugin_DeletePlugins --order-by=random
  4. Run the plugins group:
    npm run test:php -- --group plugins
  5. Run PHPCS on the test file:
    node ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/admin/includes/plugin/deletePlugins.php

Trac ticket: https://core.trac.wordpress.org/ticket/65819

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.

@huzaifaalmesbah
huzaifaalmesbah marked this pull request as ready for review October 21, 2026 04:27
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertions match the source, and CI passes. One note about fixture cleanup inline.

$slug = 'delete-test-plugin-' . ++self::$counter;
$dir = WP_PLUGIN_DIR . '/' . $slug;

$this->assertDirectoryDoesNotExist( $dir, 'The test plugin directory should not exist yet.' );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In core tests, WP_PLUGIN_DIR is tests/phpunit/data/plugins, which is a tracked directory. If a run stops partway, such as on a fatal error or Ctrl+C, tear_down() never runs and this fixture folder stays there. The slug comes from a counter that starts at 1 again on the next run, so this assertion fails on the same folder name. So every test in the class fails here until someone deletes the folder by hand. The leftover also shows up in git status.

Could this helper, or set_up(), remove a leftover folder first? #14600 already does this: its remove_plugin() helper runs in both set_up() and tear_down().

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Added a remove_path() helper in d7805bf. create_plugin_directory(), create_undeletable_plugin() and create_file() now clear a leftover path before creating it, and tear_down() uses the same helper. The class passes with leftover plugin folders, single-file plugins and undeletable folders in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants