Skip to content

Tests: Add unit test coverage for the row meta in WP_Plugins_List_Table::single_row() - #14603

Open
huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/plugins-list-table-row-meta
Open

huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/plugins-list-table-row-meta

Conversation

@huzaifaalmesbah

Copy link
Copy Markdown
Member

Description

Adds tests for the row meta that WP_Plugins_List_Table::single_row() shows under a plugin's description: the version, the author, and the View details or Visit plugin site link, plus the plugin_row_meta filter. These had no tests.

The tests render a row for a temporary plugin on the Plugins screen and read the meta from the plugin_row_meta filter. They cover:

  • the version, the author linked to the author URI, and the View details link (escaped label and title) for a plugin from the directory;
  • the author without a link and the Visit plugin site link (escaped URL) without a directory slug;
  • the Visit plugin site link instead of View details for a user who cannot install plugins;
  • empty and '0' values being left out;
  • the filter receiving the plugin file, data and status, and the links being joined with | in the row.

Removing or changing each branch of the row meta makes at least one test fail.

This is a test-only change; no production code is modified.

Testing Instructions

  1. Run the tests on single site:
    npm run test:php -- --filter Tests_Admin_wpPluginsListTableRowMeta
  2. Run them on multisite:
    npm run test:php -- --filter Tests_Admin_wpPluginsListTableRowMeta -c tests/phpunit/multisite.xml
  3. Run them in random order:
    npm run test:php -- --filter Tests_Admin_wpPluginsListTableRowMeta --order-by=random
  4. Run the plugins group:
    npm run test:php -- --group plugins
  5. Run PHPCS on the test file:
    node ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/admin/wpPluginsListTableRowMeta.php

Trac ticket: https://core.trac.wordpress.org/ticket/65819

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertions match the source, and CI passes. One note about fixture cleanup inline.

private function render( $plugin_data ) {
// is_network_only_plugin() reads the plugin headers on multisite.
$dir = WP_PLUGIN_DIR . '/' . $this->slug;
$this->assertTrue( mkdir( $dir ), 'The test plugin directory should be created.' );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In core tests, WP_PLUGIN_DIR is tests/phpunit/data/plugins, which is a tracked directory. If a run stops partway, such as on a fatal error or Ctrl+C, tear_down() never runs and this fixture folder stays there. The slug comes from a counter that starts at 1 again on the next run, so mkdir() fails on the same folder name. So every test in the class fails here until someone deletes the folder by hand. The leftover also shows up in git status.

Could this helper, or set_up(), remove a leftover folder first? #14600 already does this: its remove_plugin() helper runs in both set_up() and tear_down().

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Added a remove_plugin() helper that clears a leftover folder before mkdir() and in tear_down(), in 4f70c2e. I checked it with a leftover folder in place: the old code failed and the new code passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants