Repository navigation
Tests: Add unit test coverage for activate_plugin() - #14601
huzaifaalmesbah wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
The assertions match the source, and CI passes. One note about fixture cleanup inline.
| private function create_plugin( $headers = '', $code = '' ) { | ||
| $dir = WP_PLUGIN_DIR . '/' . $this->slug; | ||
|
|
||
| $this->assertTrue( mkdir( $dir ), 'The test plugin directory should be created.' ); |
There was a problem hiding this comment.
In core tests, WP_PLUGIN_DIR is tests/phpunit/data/plugins, which is a tracked directory. If a run stops partway, such as on a fatal error or Ctrl+C, tear_down() never runs and this fixture folder stays there. The slug comes from a counter that starts at 1 again on the next run, so mkdir() fails on the same folder name. So every test in the class fails here until someone deletes the folder by hand. The leftover also shows up in git status.
Could this helper, or set_up(), remove a leftover folder first? #14600 already does this: its remove_plugin() helper runs in both set_up() and tear_down().
There was a problem hiding this comment.
Good catch, thanks! Added a remove_plugin() helper that clears a leftover folder before mkdir() and in tear_down(), in b888f06. I checked it with a leftover folder in place: the old code failed and the new code passes.
Description
Adds tests for
activate_plugin(). The existing tests only call it throughactivate_plugins()for a single plugin; its validation, hooks, redirect, output check and network activation had no direct tests.The tests create a temporary plugin for each test (a plugin file is only loaded once per process), stop the redirect through the
wp_redirectfilter, and restore$_GET. They cover:plugin_not_foundfor a plugin that is not installed, andplugin_php_incompatiblefor unmet requirements, without changing the active plugins;activate_plugin,activate_{$plugin}andactivated_pluginfiring in order with their arguments;unexpected_outputwith the output as error data when loading the plugin prints something, while the plugin stays activated;_error_nonce;$_GET['networkwide']), a network-only plugin always being activated network-wide, and a network-active plugin keeping its activation time.Removing or changing each branch of the function makes at least one test fail on single site or multisite.
One case is left out on multisite:
activate_plugin()callsis_network_only_plugin()beforevalidate_plugin(), so a plugin that is not installed raises afile_get_contents()warning before theplugin_not_founderror is returned. That can be handled in its own ticket.This is a test-only change; no production code is modified.
Testing Instructions
npm run test:php -- --filter Tests_Admin_Includes_Plugin_ActivatePluginnpm run test:php -- --filter Tests_Admin_Includes_Plugin_ActivatePlugin -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_Admin_Includes_Plugin_ActivatePlugin --order-by=randomnpm run test:php -- --group pluginsnode ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/admin/includes/plugin/activatePlugin.phpTrac ticket: https://core.trac.wordpress.org/ticket/65819
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.