Skip to content

Plugins: Avoid undefined activateUrl key for active plugins on multisite #14541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aayushkalikote wants to merge 2 commits into
base: trunk
Choose a base branch
from
+23 −3
Open

Plugins: Avoid undefined activateUrl key for active plugins on multisite #14541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43463bf
Plugins: Avoid undefined `activateUrl` key for active plugins on mult…
Aayushkalikote Oct 20, 2026
3017b05
Merge remote-tracking branch 'upstream/trunk' into fix/66346-plugin-d…
Aayushkalikote Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/class-wp-plugin-dependencies.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ public static function check_plugin_dependencies_during_ajax() {
);
}

if ( is_multisite() && current_user_can( 'manage_network_plugins' ) ) {
if ( isset( $status['activateUrl'] ) && is_multisite() && current_user_can( 'manage_network_plugins' ) ) {
$status['activateUrl'] = add_query_arg( array( 'networkwide' => 1 ), $status['activateUrl'] );
}

Expand Down
24 changes: 22 additions & 2 deletions tests/phpunit/tests/ajax/wpAjaxCheckPluginDependencies.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,7 @@ public function test_should_not_return_activate_url_for_user_without_capability(
* Tests that no activation URL is returned for a plugin that is already active.
*
* @ticket 65819
*
* @group ms-excluded
* @ticket 66346
*/
public function test_should_not_return_activate_url_for_active_plugin() {
wp_set_current_user( self::$admin_id );
Expand All @@ -290,6 +289,27 @@ public function test_should_not_return_activate_url_for_active_plugin() {
$this->assertArrayNotHasKey( 'activateUrl', $response['data'], 'No activation URL should be returned.' );
}

/**
* Tests that no activation URL is returned for a plugin that is network-activated.
*
* @ticket 66346
*
* @group ms-required
*/
public function test_should_not_return_activate_url_for_network_active_plugin() {
wp_set_current_user( self::$admin_id );

$this->set_installed_plugins( array( 'dependent/dependent.php' => '' ) );
update_site_option( 'active_sitewide_plugins', array( 'dependent/dependent.php' => time() ) );

$_POST['slug'] = 'dependent';

$response = $this->make_request();

$this->assertTrue( $response['success'], 'The request should succeed.' );
$this->assertArrayNotHasKey( 'activateUrl', $response['data'], 'No activation URL should be returned.' );
}

/**
* Tests that a plugin whose dependencies are all active returns success.
*
Expand Down
Loading