Skip to content

Rewrite Rules: Require a path-segment boundary when stripping the home path in WP::parse_request() #13373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irozum wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Rewrite Rules: Require a path-segment boundary when stripping the home path in WP::parse_request() #13373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5044fa4
Test: reproduce WP::parse_request() stripping a prefix match of the h…
irozum Sep 2, 2026
80d6400
Rewrite Rules: Require a path-segment boundary when stripping the hom…
irozum Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/class-wp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public function parse_request( $extra_query_vars = '' ) {
$home_path_regex = '';
if ( is_string( $home_path ) && '' !== $home_path ) {
$home_path = trim( $home_path, '/' );
$home_path_regex = sprintf( '|^%s|i', preg_quote( $home_path, '|' ) );
$home_path_regex = sprintf( '!^%s(?:/|$)!i', preg_quote( $home_path, '!' ) );
}

/*
Expand Down
23 changes: 23 additions & 0 deletions tests/phpunit/tests/wp/parseRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,27 @@ static function ( $url ) {
$this->wp->parse_request();
$this->assertSame( '', $this->wp->request );
}

/**
* Tests that a requested path starting with the same characters as the home
* path, but not actually inside it, is not stripped as if it were a match.
*
* @ticket 40339
*/
public function test_pathinfo_prefix_matching_home_path_is_not_stripped() {
$this->set_permalink_structure( '/%year%/%monthnum%/%postname%/' );

add_filter(
'home_url',
static function () {
return 'http://' . WP_TESTS_DOMAIN . '/wp';
}
);

$_SERVER['PATH_INFO'] = '/wp-json/wc/v1/products';

$this->wp->parse_request();

$this->assertSame( 'wp-json/wc/v1/products', $this->wp->request );
}
}
Loading