Build/Test Tools: Swap RTL arrow icons that carry alternative text - #13361
Build/Test Tools: Swap RTL arrow icons that carry alternative text#13361itzmekhokan wants to merge 1 commit into
Conversation
The `swap-dashicons-left-right-arrows` rtlcss plugin matches each `content` value against the six arrow glyphs by exact string equality, so a declaration written with alternative text, `content: "\f141" / '';`, never matches and keeps its LTR arrow. The generated stylesheets then pair a correctly flipped fallback with an unflipped modern value. Set any alternative text aside before the comparison and restore it after, so both declarations agree. This corrects 17 declarations across seven stylesheets, including the toolbar submenu arrows. Fixes #66020.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
In RTL admin screens some dashicons arrows point the wrong way, with the old-browser fallback flipped correctly and the modern value not flipped.
The
swap-dashicons-left-right-arrowsrtlcss plugin inGruntfile.jscompares eachcontentvalue against the six arrow glyphs by exact string equality, so a declaration written with alternative text, as incontent: "\f141" / '';, never matches. This sets the alternative text aside before the comparison and restores it afterwards.Seventeen declarations across seven generated stylesheets change, including the toolbar submenu arrows named in the ticket.
Trac ticket: https://core.trac.wordpress.org/ticket/66020
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: diagnosing the rtlcss value comparison and drafting the Gruntfile change. All changes were reviewed and validated by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.