Skip to content

Build/Test Tools: Swap RTL arrow icons that carry alternative text - #13361

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/rtl-dashicons-arrow-alt-text
Open

Build/Test Tools: Swap RTL arrow icons that carry alternative text#13361
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/rtl-dashicons-arrow-alt-text

Conversation

@itzmekhokan

Copy link
Copy Markdown

In RTL admin screens some dashicons arrows point the wrong way, with the old-browser fallback flipped correctly and the modern value not flipped.

The swap-dashicons-left-right-arrows rtlcss plugin in Gruntfile.js compares each content value against the six arrow glyphs by exact string equality, so a declaration written with alternative text, as in content: "\f141" / '';, never matches. This sets the alternative text aside before the comparison and restores it afterwards.

Seventeen declarations across seven generated stylesheets change, including the toolbar submenu arrows named in the ticket.

Trac ticket: https://core.trac.wordpress.org/ticket/66020

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: diagnosing the rtlcss value comparison and drafting the Gruntfile change. All changes were reviewed and validated by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

The `swap-dashicons-left-right-arrows` rtlcss plugin matches each
`content` value against the six arrow glyphs by exact string equality, so
a declaration written with alternative text, `content: "\f141" / '';`,
never matches and keeps its LTR arrow. The generated stylesheets then
pair a correctly flipped fallback with an unflipped modern value.

Set any alternative text aside before the comparison and restore it
after, so both declarations agree. This corrects 17 declarations across
seven stylesheets, including the toolbar submenu arrows.

Fixes #66020.
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant