Skip to content

Admin Menu: Fix multiple active menu highlights on mobile.#11902

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65280
Open

Admin Menu: Fix multiple active menu highlights on mobile.#11902
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65280

Conversation

@itzmekhokan
Copy link
Copy Markdown

Use :focus-visible for admin menu focus indicators so touch taps do not leave a stale active appearance on previously selected items. Clear the responsive selected state when another top-level menu is opened or when navigating via a submenu link. Limit admin menu view transitions to the current menu item to avoid overlapping active styles during navigation.

Fixes #65280.

Trac ticket: https://core.trac.wordpress.org/ticket/65280

Use :focus-visible for admin menu focus indicators so touch taps do not
leave a stale active appearance on previously selected items. Clear the
responsive selected state when another top-level menu is opened or when
navigating via a submenu link. Limit admin menu view transitions to the
current menu item to avoid overlapping active styles during navigation.

Fixes #65280.
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant