Skip to content

Use floor() instead of round() in rest_is_integer()#11893

Open
siliconforks wants to merge 10 commits into
WordPress:trunkfrom
siliconforks:65271-floor
Open

Use floor() instead of round() in rest_is_integer()#11893
siliconforks wants to merge 10 commits into
WordPress:trunkfrom
siliconforks:65271-floor

Conversation

@siliconforks
Copy link
Copy Markdown

@siliconforks siliconforks commented May 20, 2026

This fixes a problem with large integers causing rest_is_integer() to return false.

It also adds some tests for large integers and a few other things that did not have any existing tests (negative floats, scientific notation).

To run the test suite:

vendor/bin/phpunit --filter Tests_REST_API

Trac ticket: https://core.trac.wordpress.org/ticket/65271

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Opus 4.7
Used for: @westonruter said that Claude Opus 4.7 made suggestions to add separate branches for int values and string integers; these looked fine to me, so I added them.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props siliconforks, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment thread tests/phpunit/tests/rest-api.php Outdated
Comment thread tests/phpunit/tests/rest-api.php Outdated
Comment thread tests/phpunit/tests/rest-api.php Outdated
Comment thread src/wp-includes/rest-api.php Outdated
Comment thread tests/phpunit/tests/rest-api.php Outdated
Comment thread tests/phpunit/tests/rest-api.php Outdated
Comment thread src/wp-includes/rest-api.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants