Use floor() instead of round() in rest_is_integer()#11893
Use floor() instead of round() in rest_is_integer()#11893siliconforks wants to merge 10 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Change suggested by @westonruter and Claude Opus 4.7.
This fixes a problem with large integers causing
rest_is_integer()to returnfalse.It also adds some tests for large integers and a few other things that did not have any existing tests (negative floats, scientific notation).
To run the test suite:
Trac ticket: https://core.trac.wordpress.org/ticket/65271
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Opus 4.7
Used for: @westonruter said that Claude Opus 4.7 made suggestions to add separate branches for
intvalues andstringintegers; these looked fine to me, so I added them.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.