Skip to content

Ajax: Add unit tests for wp_ajax_delete_link() - #11872

Open
pbearne wants to merge 6 commits into
WordPress:trunkfrom
pbearne:65252-ajax-actions-delete_link
Open

pbearne wants to merge 6 commits into
WordPress:trunkfrom
pbearne:65252-ajax-actions-delete_link

Conversation

@pbearne

@pbearne pbearne commented May 19, 2026

Copy link
Copy Markdown

This PR adds unit tests for the wp_ajax_delete_link() function located in src/wp-admin/includes/ajax-actions.php.
The tests cover:

  • Successful deletion of links (bookmarks).
  • Proper handling of invalid nonces.
  • Verification of user permissions (manage_links capability).
  • Behavior when attempting to delete a non-existent link ID (idempotent success).

Note: The tests enable the link_manager_enabled option to allow the manage_links capability to be correctly checked, as the Link Manager is disabled by default in modern WordPress.

Trac ticket: https://core.trac.wordpress.org/ticket/65252

AI Disclosure:

  • AI assistance: Yes
  • Tool(s): Junie (JetBrains)
  • Model(s): gemini-3-flash-preview
  • Used for: Code analysis, test implementation, and workflow management.

Co-authored-by: Junie <junie@jetbrains.com>
@github-actions

github-actions Bot commented May 19, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org, @mindctrl.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@lancewillett

Copy link
Copy Markdown
Member

Thanks, @pbearne. Two changes, explained in #65252 comment:66: drop the admin_init hook in set_up(), and move the assertions out of catch.

pbearne and others added 3 commits October 21, 2026 16:46
… assertions

- Refactor factory usage to align with static methods.
- Replace `delete_link` action with `delete-link` for consistency.
- Update exception handling to separate expected outcomes.
- Simplify assertions for better readability.
Comment thread tests/phpunit/tests/admin/includes/ajax-actions/deleteLink.php
Co-authored-by: John Parris <public@johnparris.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants