Enable visualRefresh on all sample maps - #137
Draft
manz wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
gaelsimon
approved these changes
Aug 25, 2026
Member
Author
|
This is likely to be useless to do that switch unless the plan of making it the default falls flat |
manz
marked this pull request as draft
September 4, 2026 07:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Describe your changes
Opt every sample map into the refreshed basemap styles by passing
visualRefresh: truein theMapOptionsof eachwoosmap.map.Mapinstantiation (58 samples, 59 call sites —map-external-layerbuilds two maps).stores-searchandstores-list-sync-mapshare amapOptionsconst, so the flag is set there.Widget-driven samples (
store-locator-widget*,localities-js-widget*,indoor-widget-*conf blocks) expose noMapOptions, so they keep the widget default. Theindoor-*samples that build their ownMapare covered.The flag is transitional — it disappears once the refreshed styles become the default, at which point this diff can be reverted wholesale.
How to test
npm start, open http://localhost:8080/stylesarray:map-style-night,map-style-retro,map-style-lightgrey,map-clustering-stores.map-type-hybridsatellite/hybrid switching is unaffected.Checklist:
Documentation
Docs snippets are generated from these samples — published examples will show
visualRefresh: true. Confirm that's wanted before the flag ships as default.Libs/SDKs
N/A