Skip to content

Enable visualRefresh on all sample maps - #137

Draft
manz wants to merge 1 commit into
masterfrom
visual-refresh-samples
Draft

Enable visualRefresh on all sample maps#137
manz wants to merge 1 commit into
masterfrom
visual-refresh-samples

Conversation

@manz

@manz manz commented Aug 25, 2026

Copy link
Copy Markdown
Member

Issue

N/A

Describe your changes

Opt every sample map into the refreshed basemap styles by passing visualRefresh: true in the MapOptions of each woosmap.map.Map instantiation (58 samples, 59 call sites — map-external-layer builds two maps). stores-search and stores-list-sync-map share a mapOptions const, so the flag is set there.

Widget-driven samples (store-locator-widget*, localities-js-widget*, indoor-widget-* conf blocks) expose no MapOptions, so they keep the widget default. The indoor-* samples that build their own Map are covered.

The flag is transitional — it disappears once the refreshed styles become the default, at which point this diff can be reverted wholesale.

How to test

  1. npm start, open http://localhost:8080/
  2. Open any sample's live frame, e.g. http://localhost:8080/samples/add-map/iframe/ — basemap should render with the refreshed styles.
  3. Check styled samples still honour their own styles array: map-style-night, map-style-retro, map-style-lightgrey, map-clustering-stores.
  4. Check map-type-hybrid satellite/hybrid switching is unaffected.

Checklist:

  • My code follows the style guidelines for this repo
  • My code passes the SonarCloud check and does not add new code smells
  • I have performed a self-review of my code
  • My changes generate no new warnings/errors
  • I have added tests that prove my fix is effective or that my feature works
  • I don't require ops changes for this PR to go to prod
  • This change does not include a migration

Documentation

Docs snippets are generated from these samples — published examples will show visualRefresh: true. Confirm that's wanted before the flag ships as default.

Libs/SDKs

N/A

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@manz

manz commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

This is likely to be useless to do that switch unless the plan of making it the default falls flat

@manz
manz marked this pull request as draft September 4, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants