Skip to content

Fix one-time consent for external media - #6701

Open
SoftCreatR wants to merge 1 commit into
WoltLab:6.2from
SoftCreatR:bugfix/external-media-consent
Open

Fix one-time consent for external media#6701
SoftCreatR wants to merge 1 commit into
WoltLab:6.2from
SoftCreatR:bugfix/external-media-consent

Conversation

@SoftCreatR

Copy link
Copy Markdown
Contributor

The Fancybox consent plugin only handles permanently enabling external media. Clicking “Display content once” still invokes the generic user-consent handler, which expects a target or payload and can attempt to insert content relative to an already detached consent element.

This results in an empty Fancybox slide and the following error:

The reference element has no parent, but the insert position was set to 'before'.

This PR handles one-time consent directly in the Fancybox plugin:

  • Restores the original media type for the current slide.
  • Refreshes the current slide so the external media is loaded.
  • Prevents the generic payload-based consent handler from processing the Fancybox button.
  • Leaves permanent consent behavior unchanged.

@SoftCreatR
SoftCreatR force-pushed the bugfix/external-media-consent branch from fda17eb to a879830 Compare July 29, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant