fix(ci): skip the query-based LSP-hang tests to cure the CI hang (closes #303)#321
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
#303) test_query_confidence_without_deep and test_deep_with_pyright invoke the `query` hidden command, whose LSP initialisation hangs on headless CI — the single hang that made every CI run burn GitHub's 6h ceiling and read as "cancelled" (60+ runs, zero green). #304 capped it and #318 added subprocess timeouts so runs now COMPLETE (~2m39s), but the tests still hit the timeout. Skip both with a documented reason. test_query's assertion (confidence present without --deep) is already covered by test_impact_confidence_without_deep via the `impact` umbrella, which never touches LSP — so no coverage is lost. The real fix (make `query` LSP-safe, or drop it) rides with the resolution of the 13 hidden commands (#200); the skips reference it for re-enablement. Verified: both tests skip with reason; full suite 19 failures = 19 on main (the remaining 19 are #271 pagination + Windows-env, unrelated to the hang). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #303 (P0). The cure for the hang whose guard landed in #304.
Yang diperbaiki
test_query_confidence_without_deep&test_deep_with_pyrightmemanggilquery(hidden command #200), yang LSP-init-nya hang di headless CI — satu-satunya hang yang membuat tiap run CI membakar batas 6 jam GitHub dan terbacacancelled(60+ run, nol hijau).Rantai penyelesaian:
timeout-minutes+pytest-timeout→ hang di-kill, run SELESAI (2m39s, bukan 6 jam).timeout=60→ gagal lebih cepat + ekspos 3 test vacuous.Kenapa skip aman
Assertion test_query (confidence tanpa
--deep) sudah dicovertest_impact_confidence_without_deepvia umbrellaimpactyang tak menyentuh LSP — nol coverage hilang. Fix sebenarnya (buatqueryLSP-safe atau hapus) ikut resolusi 13 hidden command (#200); skip mereferensikannya untuk re-enable. DoD #303 mengizinkan skip-with-reason + issue lanjutan.Verifikasi (dijalankan)
Gate CI kini SELESAI dengan hasil nyata, tanpa hang. P0 tertutup.
🤖 Generated with Claude Code