Skip to content

Handle combatant info not containing spec ids for "players in fight" api endpoint#74

Merged
emallson merged 1 commit intoWoWAnalyzer:mainfrom
Krealle:player-details-missing-combatant-info
Jan 9, 2026
Merged

Handle combatant info not containing spec ids for "players in fight" api endpoint#74
emallson merged 1 commit intoWoWAnalyzer:mainfrom
Krealle:player-details-missing-combatant-info

Conversation

@Krealle
Copy link
Contributor

@Krealle Krealle commented Jan 9, 2026

combatantInfo can be empty which causes the endpoint to throw when trying to access the spec ids.

{
  name: 'Melinoé',
  id: 33,
  guid: 101415068,
  type: 'Druid',
  server: "Shek'zeer",
  region: 'EU',
  icon: 'Druid-Feral',
  specs: [ { spec: 'Feral', count: 1 } ],
  minItemLevel: 524,
  maxItemLevel: 524,
  potionUse: 0,
  healthstoneUse: 0,
  combatantInfo: []
}
{"level":30,"time":1767987260652,"pid":135390,"hostname":"","reqId":"req-3","req":{"method":"GET","url":"/i/v2/report/zQtqGWjMkPh48b6V/fight/1/players","hostname":"localhost:3001","remoteAddress":"127.0.0.1","remotePort":52282},"msg":"incoming request"}
TypeError: Cannot read properties of undefined (reading '0')
    at extractPlayerDetails (.../wowa-server/src/route/wcl/fight-players.ts:63:35)
image

Copy link
Contributor

@emallson emallson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dammit, good catch

@emallson emallson merged commit 6fcf22c into WoWAnalyzer:main Jan 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants