Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #381.
With #421, we now know how SAS determines the padding between subheaders and data on mixed pages when reading sas7bdat files. We can use this information to remove a hack in the sas7bdat reader that currently more or less guesses the padding and guesses wrong in the context of issue #381.
I've removed all parsing and validation of the version string except for the major version, which is exposed through the API. Any further parsing and validation can result in unnecessary obstacles as seen in #379.
If you'd prefer to keep some of it, for example for the minor version, please let me know.
I've validated the change against both big-endian and little-endian as well as 64-bit (which always have 0 padding) and 32-bit sas7bdat files as produced by SAS 9.4.
I don't have access to sas7bdat files created by Stat/Transfer. But if Stat/Transfer produces sas7bdat files that are readable by SAS, then it must produce the right padding value as SAS will make read errors if the padding is off (see #421).