Repository navigation
Conversation
The `[missing.granit-parser]` entry is pinned to 1.3.0. serde-saphyr 1 -> 2, arriving through saorsa-transport, moved granit-parser to 2.1.0, so the entry no longer matches and the release build fails at THIRD-PARTY-NOTICES on every target with "no crate-level licence file contains the text of an allowed option". Only the release workflow runs the generator, so this surfaces after a tag push rather than on a pull request. 2.1.0 is unchanged in every respect the entry describes: it still declares MIT OR Apache-2.0, and its root LICENSE still only refers to texts under the hidden .licenses directory the generator does not search, with the same attributions to Chen Yuheng, Ethiraric and Bourumir Wyngs. The SPDX MIT text and its sha256 are version-independent, so only the version pin needed moving. Verified by running the generator for x86_64-unknown-linux-musl, which now completes instead of raising a gap. The same fix is already on rc-2026.11.1; this carries it to main so the next release candidate cuts clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the
[missing.granit-parser]entry inscripts/third_party_notices/config.tomlfromversion = "1.3.0"to"2.1.0".Why
serde-saphyr1 → 2, arriving throughsaorsa-transport, movedgranit-parserto 2.1.0. Theentry is version-pinned, so it stopped matching and the notices generator reopened the gap:
That failed every build target on both rc tags of the 2026-11-05 release train before anything
published. Only the release workflow runs the generator, so a transitive version move surfaces
after a tag push rather than on a pull request.
Is 2.1.0 still the same case?
Checked against the published crate, not assumed. 2.1.0 still declares
license = "MIT OR Apache-2.0", and its rootLICENSEstill only refers to texts under the hidden.licensesdirectory the generator does not search, carrying the same attributions to Chen Yuheng, Ethiraric
and Bourumir Wyngs. The entry's
text_urlandtext_sha256point at the SPDX MIT text, which isversion-independent. So the note remains accurate and only the version pin needed moving.
Verification
python3 scripts/third_party_notices/generate.py --config scripts/third_party_notices/config.toml --output /tmp/notices.txt --target x86_64-unknown-linux-muslnow completes instead of raising agap, with
granit-parserpresent in the output.The same one-line fix is already on
rc-2026.11.1; this carries it tomainso the next releasecandidate cuts clean.
Risk tier
Semver impact
🤖 Generated with Claude Code