Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This initial commit sets up the project scaffold for ShopifyNet and ShopifyNetApp with minimal code and configuration to support a GraphQL type generator utility.
- Added project files for both ShopifyNet and ShopifyNetApp with basic csproj configurations.
- Introduced a generator script in ShopifyNetApp.cs that reads a JSON schema and generates type definitions in an output path.
- Configured solution, build properties, VS Code settings, and a GitHub Actions workflow for CI/CD.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ShopifyNetApp/ShopifyNetApp.csproj | New project configuration with GraphQLSharp dependency. |
| ShopifyNetApp/ShopifyNetApp.cs | Initial GraphQL type generator implementation. |
| ShopifyNet/ShopifyNet.csproj | Package project settings for utility library. |
| ShopifyNet/ShopifyNet.cs | Scaffold for the ShopifyNet namespace and class. |
| ShopifyNet.sln | Solution file linking both projects. |
| Directory.Build.props | Global build properties including target framework. |
| .vscode/settings.json | Basic VS Code settings for the solution. |
| .github/workflows/ci.yml | CI workflow configuration for build, test, and publish. |
Comments suppressed due to low confidence (1)
ShopifyNetApp/ShopifyNetApp.cs:7
- [nitpick] Consider aligning the Namespace value ('shopify') with the project naming conventions (e.g., 'ShopifyNetApp') to avoid potential confusion.
Namespace = "shopify",
…om/Wish-Org/ShopifyNet into feat/create-initial-project-layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.