Conversation
Member
|
Thanks @wetneb, I was hoping to perform some changes before merging to master, like switching from postgres to mariadb, using toolforge's image instead of the docker hub's python image, etc. |
* use MariaDB instead of Postgres * use Toolforge's python image * use docker.py settings as secret, and use dev * remove docker-entrypoint and use that in docker-compose
Member
|
after a long time, @wetneb , I made docker closer to Toolforge :D |
Member
|
@ternera thanks so much for starting this. take a look on the changes I did, making docker closer to our current Toolforge environment :-) |
Contributor
Excellent work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking for @ternera's contributions on the master branch and couldn't find them, which I found confusing ^^
I'm opening this PR as a reminder that those commits should make it to the master branch at some point :)