Replace Consolidations feature with Pattern Replacement#1029
Open
scottkleinman wants to merge 6 commits intomasterfrom
Open
Replace Consolidations feature with Pattern Replacement#1029scottkleinman wants to merge 6 commits intomasterfrom
scottkleinman wants to merge 6 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 58.92% 58.54% -0.38%
==========================================
Files 40 40
Lines 3175 3199 +24
==========================================
+ Hits 1871 1873 +2
- Misses 1304 1326 +22
Continue to review full report at Codecov.
|
Contributor
Author
|
The frontend refactor of the last couple of days will make it very hard to merge this branch into master. I recommend just using this branch to test for UX and optimisation. If it works, the changes can be re-created in a new branch based on the latest version of master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major change, replacing the old Consolidations feature with a new Pattern Replacement feature that implements a general pattern replacement function accepting regex patterns. It needs a review for UX and code efficiency. It probably also needs a unit test set up (volunteers?).