Skip to content

Fix ruff E402 in build_all_github.py - #23

Merged
Wewoc merged 1 commit into
mainfrom
claude/magical-ritchie-807x8r
Sep 30, 2026
Merged

Wewoc merged 1 commit into
mainfrom
claude/magical-ritchie-807x8r

Conversation

@Wewoc

@Wewoc Wewoc commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Summary

test-suite.yml's test_static.py (ruff check) caught this on the v1.7.3.4 doc-chain push (run #6, #5): os.environ.setdefault()/sys.stdout.reconfigure() were placed between the stdlib imports and import requests/import build_all in compiler/build_all_github.py, triggering E402. Neither call needs to run before those imports — moved below them, no behavior change. Verified clean with ruff check locally.

Test plan

  • ruff check build_all_github.py passes locally
  • Next push to main should show test-suite.yml green again

🤖 Generated with Claude Code

https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g


Generated by Claude Code

test-suite.yml's test_static.py (ruff check) caught this on the
v1.7.3.4 doc-chain push: os.environ.setdefault()/sys.stdout.reconfigure()
were placed between the stdlib imports and `import requests`/
`import build_all`, triggering E402 (module level import not at top of
file). Neither call actually needs to run before those imports —
build_all's own GLA_BUILD_VENV_DIR read and this module's prints both
happen later, inside main(). Moved below the imports; verified clean
with `ruff check` locally.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g
@Wewoc
Wewoc merged commit dd49f11 into main Sep 30, 2026
1 check passed
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: bd4a2162-49c9-40cf-a1e8-ac58471093a5

📥 Commits

Reviewing files that changed from the base of the PR and between 0589717 and f05e4c9.

📒 Files selected for processing (1)
  • src/compiler/build_all_github.py
 _____________________________________________________
< Code Wars Episode III: Revenge of the Shared State. >
 -----------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wewoc
Wewoc deleted the claude/magical-ritchie-807x8r branch October 1, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants