Repository navigation
Fix ruff E402 in build_all_github.py - #23
Merged
Merged
Conversation
test-suite.yml's test_static.py (ruff check) caught this on the v1.7.3.4 doc-chain push: os.environ.setdefault()/sys.stdout.reconfigure() were placed between the stdlib imports and `import requests`/ `import build_all`, triggering E402 (module level import not at top of file). Neither call actually needs to run before those imports — build_all's own GLA_BUILD_VENV_DIR read and this module's prints both happen later, inside main(). Moved below the imports; verified clean with `ruff check` locally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-suite.yml'stest_static.py(ruff check) caught this on the v1.7.3.4 doc-chain push (run #6, #5):os.environ.setdefault()/sys.stdout.reconfigure()were placed between the stdlib imports andimport requests/import build_allincompiler/build_all_github.py, triggering E402. Neither call needs to run before those imports — moved below them, no behavior change. Verified clean withruff checklocally.Test plan
ruff check build_all_github.pypasses locallymainshould showtest-suite.ymlgreen again🤖 Generated with Claude Code
https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g
Generated by Claude Code