Skip to content

Add experimental probe for build_manifest.py's hardcoded D: venv path - #18

Merged
Wewoc merged 1 commit into
mainfrom
claude/magical-ritchie-807x8r
Sep 30, 2026
Merged

Wewoc merged 1 commit into
mainfrom
claude/magical-ritchie-807x8r

Conversation

@Wewoc

@Wewoc Wewoc commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • workflow_dispatch-only, experimental. Checks whether D:\Garmin\.venv_gla (build_manifest.BUILD_VENV_DIR, hardcoded for local dev machines) works on a windows-latest GitHub Actions runner: D: drive presence/writability, venv creation, installing requirements.txt + PyInstaller into it.
  • Purpose: de-risk before wiring the real PyInstaller build into a CI workflow (build_all_github.py), same "probe before committing" approach already used for the pytest-qt display question.

Test plan

  • Trigger via workflow_dispatch after merge, confirm D:\Garmin.venv_gla is viable

🤖 Generated with Claude Code

https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g


Generated by Claude Code

Checks whether D:\Garmin\.venv_gla (build_manifest.BUILD_VENV_DIR,
hardcoded for local dev machines) is viable on a windows-latest
GitHub Actions runner, before wiring the real build (build_all.py /
PyInstaller) into a CI workflow. workflow_dispatch-only, not part of
any automatic trigger.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g
@Wewoc
Wewoc merged commit e97c124 into main Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 33c036f0-a21c-41a0-8db7-c21b5f389d0a

📥 Commits

Reviewing files that changed from the base of the PR and between 0dd0dce and 77283a6.

📒 Files selected for processing (1)
  • .github/workflows/build-venv-probe.yml
 _______________________________
< Yippee-ki-yay, mother-bugger! >
 -------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants