Repository navigation
Wire run_tests.ps1 into a permanent CI workflow (Windows) - #17
Merged
Merged
Conversation
test-suite.yml replaces the experimental windows-test-feasibility.yml probe (which already confirmed run_tests.ps1 works cleanly on windows-latest, even without QT_QPA_PLATFORM=offscreen — kept here anyway for pytest-qt robustness). Runs on push/main, same trigger pattern as the other three workflows. Purpose per discussion: not a merge gate (pushes to main are already tested locally first) — this is for public transparency/trust, showing real test results on every push. run_tests.ps1 itself never propagates a non-zero exit code on test failure (no $LASTEXITCODE check, no `exit` call anywhere in the script) — a naive `pwsh -File run_tests.ps1` CI step would always report success regardless of actual failures, defeating the transparency purpose. Added a post-step that parses test_all_log.txt's per-suite "N checks — N passed, M failed" summary lines and fails the job if any M > 0, without modifying run_tests.ps1 itself. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-test-feasibility.ymlprobe with a permanenttest-suite.yml, now that the feasibility question is answered (pytest-qt runs cleanly onwindows-latest, even withoutQT_QPA_PLATFORM=offscreen— kept it set anyway for robustness).push/main, matching the other three workflows (vulture-check, cve-check, license-scan). Not intended as a merge gate — pushes tomainare already tested locally first — this is for public transparency/trust: real test results visible on every push.run_tests.ps1itself never sets a non-zero exit code on test failure (no$LASTEXITCODEcheck orexitcall in the script) — wiring it in naively would always report green regardless of actual failures. Added a post-step that parsestest_all_log.txt's per-suite "N checks — N passed, M failed" summary lines and fails the job if any suite has failures, without touchingrun_tests.ps1itself.test_all_log.txtas a build artifact either way.Test plan
mainafter merge to confirm the workflow passes with the current (passing) test suite🤖 Generated with Claude Code
https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g
Generated by Claude Code