Skip to content

Wire run_tests.ps1 into a permanent CI workflow (Windows) - #17

Merged
Wewoc merged 1 commit into
mainfrom
claude/magical-ritchie-807x8r
Sep 30, 2026
Merged

Wewoc merged 1 commit into
mainfrom
claude/magical-ritchie-807x8r

Conversation

@Wewoc

@Wewoc Wewoc commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Replaces the experimental windows-test-feasibility.yml probe with a permanent test-suite.yml, now that the feasibility question is answered (pytest-qt runs cleanly on windows-latest, even without QT_QPA_PLATFORM=offscreen — kept it set anyway for robustness).
  • Triggers on push/main, matching the other three workflows (vulture-check, cve-check, license-scan). Not intended as a merge gate — pushes to main are already tested locally first — this is for public transparency/trust: real test results visible on every push.
  • run_tests.ps1 itself never sets a non-zero exit code on test failure (no $LASTEXITCODE check or exit call in the script) — wiring it in naively would always report green regardless of actual failures. Added a post-step that parses test_all_log.txt's per-suite "N checks — N passed, M failed" summary lines and fails the job if any suite has failures, without touching run_tests.ps1 itself.
  • Uploads test_all_log.txt as a build artifact either way.

Test plan

  • Regex for parsing the summary block verified locally against a synthetic log (including a failure case) — correctly extracts and sums failed counts
  • Trigger a run on main after merge to confirm the workflow passes with the current (passing) test suite

🤖 Generated with Claude Code

https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g


Generated by Claude Code

test-suite.yml replaces the experimental windows-test-feasibility.yml
probe (which already confirmed run_tests.ps1 works cleanly on
windows-latest, even without QT_QPA_PLATFORM=offscreen — kept here
anyway for pytest-qt robustness). Runs on push/main, same trigger
pattern as the other three workflows.

Purpose per discussion: not a merge gate (pushes to main are already
tested locally first) — this is for public transparency/trust,
showing real test results on every push.

run_tests.ps1 itself never propagates a non-zero exit code on test
failure (no $LASTEXITCODE check, no `exit` call anywhere in the
script) — a naive `pwsh -File run_tests.ps1` CI step would always
report success regardless of actual failures, defeating the
transparency purpose. Added a post-step that parses
test_all_log.txt's per-suite "N checks — N passed, M failed" summary
lines and fails the job if any M > 0, without modifying run_tests.ps1
itself.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g
@Wewoc
Wewoc merged commit 0dd0dce into main Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 382d33b2-5fc3-4461-9ba9-2f381116bd79

📥 Commits

Reviewing files that changed from the base of the PR and between 3494b0a and c32a549.

📒 Files selected for processing (2)
  • .github/workflows/test-suite.yml
  • .github/workflows/windows-test-feasibility.yml
 ________________________________________________________________
< Fully armed and operationally intelligent code reviewer bunny. >
 ----------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants