Repository navigation
Fix Vulture whitelist path-separator mismatch on Linux CI - #16
Merged
Merged
Conversation
vulture_whitelist.py's keys use Windows backslashes (per its own docstring: "same path separator it printed — Windows backslashes"), but Vulture on ubuntu-latest reports forward slashes. The exact-tuple match in filter_whitelisted() silently failed for every whitelisted entry that has a subdirectory, so the first CI run of vulture-check.yml showed 60 "new" findings that are actually already documented false positives (openpyxl style attributes, Qt event handlers, fake-module registration, etc.) — only bare-filename entries matched by coincidence. Normalizes both sides to forward slashes before comparing, so the whitelist works the same on Windows and Linux. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vulture-check.yml(added in Add Vulture/CVE CI gates, switch license-scan to push/main #15) failed on its firstpush/mainrun: 60 "new" findings, only 4 filtered.vulture_whitelist.py's keys use Windows backslashes (its own docstring: "same path separator it printed — Windows backslashes"), but Vulture onubuntu-latestreports forward slashes.filter_whitelisted()'s exact-tuple match silently failed for every whitelisted entry with a subdirectory — only bare-filename entries (no directory) matched by coincidence.__path__/__package__registration, etc.) — not new dead code.check_vulture.py'sfilter_whitelisted().Verified locally against the actual CI findings from the failed run — all 5 spot-checked entries (including subdirectory paths) now match correctly.
Test plan
vulture-check.ymlonmainafter merge to confirm the check goes green🤖 Generated with Claude Code
https://claude.ai/code/session_01JYLx9STTgfo9KXLC2Gog3g
Generated by Claude Code