Skip to content

Add KEY_TV key mapping for libwpe impl #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asurdej-comcast wants to merge 1 commit into
base: wpe-2.46
Choose a base branch
from
+6 −3
Open

Add KEY_TV key mapping for libwpe impl #1726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/WebCore/platform/PlatformKeyboardEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ namespace WebCore {
#endif

#if USE(LIBWPE)
static String keyValueForWPEKeyCode(unsigned);
static String keyValueForWPEKeyCode(unsigned, unsigned);
static String keyCodeForHardwareKeyCode(unsigned);
static String keyIdentifierForWPEKeyCode(unsigned);
static int windowsKeyCodeForWPEKeyCode(unsigned);
Expand Down
5 changes: 4 additions & 1 deletion Source/WebCore/platform/libwpe/PlatformKeyboardEventLibWPE.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ namespace WebCore {
// more like what Firefox does, and generate these switch statements
// at build time.
// https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key/Key_Values
String PlatformKeyboardEvent::keyValueForWPEKeyCode(unsigned keyCode)
String PlatformKeyboardEvent::keyValueForWPEKeyCode(unsigned keyCode, unsigned hwKeyCode)
{
if (keyCode == 0 && hwKeyCode == 0x181) // KEY_TV
return "TV"_s;

switch (keyCode) {
// Modifier keys.
case WPE_KEY_Alt_L:
Expand Down
2 changes: 1 addition & 1 deletion Source/WebKit/Shared/libwpe/WebEventFactory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ WebKeyboardEvent WebEventFactory::createWebKeyboardEvent(struct wpe_input_keyboa
{
return WebKeyboardEvent({ event->pressed ? WebEventType::KeyDown : WebEventType::KeyUp, modifiersForKeyboardEvent(event), wallTimeForEventTime(event->time) },
text.isNull() ? WebCore::PlatformKeyboardEvent::singleCharacterString(event->key_code) : text,
WebCore::PlatformKeyboardEvent::keyValueForWPEKeyCode(event->key_code),
WebCore::PlatformKeyboardEvent::keyValueForWPEKeyCode(event->key_code, event->hardware_key_code),
WebCore::PlatformKeyboardEvent::keyCodeForHardwareKeyCode(event->hardware_key_code),
WebCore::PlatformKeyboardEvent::keyIdentifierForWPEKeyCode(event->key_code),
WebCore::PlatformKeyboardEvent::windowsKeyCodeForWPEKeyCode(event->key_code),
Expand Down