-
Notifications
You must be signed in to change notification settings - Fork 41
Update SpeechRecognitionResult with audio timing attributes #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,6 +120,8 @@ This does not preclude adding support for this as a future API enhancement, and | |
| <li>The user agent may also give the user a longer explanation the first time speech input is used, to let the user know what it is and how they can tune their privacy settings to disable speech recording if required.</li> | ||
|
|
||
| <li>To mitigate the risk of fingerprinting, user agents MUST NOT personalize speech recognition when performing speech recognition on a {{MediaStreamTrack}}.</li> | ||
|
|
||
| <li>To mitigate fingerprinting vectors associated with high-precision timing, user agents MUST apply timestamp fuzzing and precision reduction to {{SpeechRecognitionResult/audioStartTime}} and {{SpeechRecognitionResult/audioEndTime}} before exposing these attributes to scripts (e.g. by rounding to 2ms precision).</li> | ||
| </ol> | ||
|
|
||
| <h3 id="implementation-considerations">Implementation considerations</h3> | ||
|
|
@@ -258,6 +260,8 @@ interface SpeechRecognitionResult { | |
| readonly attribute unsigned long length; | ||
| getter SpeechRecognitionAlternative item(unsigned long index); | ||
| readonly attribute boolean isFinal; | ||
| readonly attribute DOMHighResTimeStamp? audioStartTime; | ||
|
alan33d marked this conversation as resolved.
|
||
| readonly attribute DOMHighResTimeStamp? audioEndTime; | ||
| }; | ||
|
|
||
| // A collection of responses (used in continuous mode) | ||
|
|
@@ -356,6 +360,16 @@ interface SpeechRecognitionPhrase { | |
| </dd> | ||
| </dl> | ||
|
|
||
| <h4 id="speechrecoresult-attributes">SpeechRecognitionResult Attributes</h4> | ||
|
|
||
| <dl> | ||
| <dt><dfn attribute for=SpeechRecognitionResult>audioStartTime</dfn> attribute</dt> | ||
| <dd>A nullable {{DOMHighResTimeStamp}} representing the start of the audio segment corresponding to this recognition result, in milliseconds relative to the start of the audio stream. Returns null if the underlying recognition engine does not support audio segment start timestamps.</dd> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We use seconds throughout those APIs, or microseconds in codec APIs. 64-bits floating point numbers have enough resolution here at even high sample rates, and it means we're not going to convert to/from seconds. I don't think those should be nullalble. If your backend doesn't support timestamping, it can be implemented, or you can ship something decent (in the sense that it's going to be accurate enough for a lot of use case) in front of it. We tend (not 100%) to not specificy APIs because of certain technologies limitations. Instead, we improve those technologies and write a good spec. As discussed in the other PR, "relative to the start of the audio stream" is very fuzzy. How does it work if you get a Why is this not |
||
|
|
||
| <dt><dfn attribute for=SpeechRecognitionResult>audioEndTime</dfn> attribute</dt> | ||
| <dd>A nullable {{DOMHighResTimeStamp}} representing the end of the audio segment corresponding to this recognition result, in milliseconds relative to the start of the audio stream. Returns null if the underlying recognition engine does not support audio segment end timestamps.</dd> | ||
| </dl> | ||
|
|
||
| <p class=issue>The group has discussed whether WebRTC might be used to specify selection of audio sources and remote recognizers. | ||
| See <a href="https://lists.w3.org/Archives/Public/public-speech-api/2012Sep/0072.html">Interacting with WebRTC, the Web Audio API and other external sources</a> thread on public-speech-api@w3.org.</p> | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a useful mitigation is it? Think about how you'd implement the same ASR system in WASM, will it be limited? It's absolutely trivial to implement
audioStartTimeetc. in WASM, and it will be sample-accurate w.r.t the audio stream.