[js-api] Accept anyref and funcref in ValueType and TableKind - #2239
Open
chicoxyzzy wants to merge 1 commit into
Open
[js-api] Accept anyref and funcref in ValueType and TableKind#2239chicoxyzzy wants to merge 1 commit into
chicoxyzzy wants to merge 1 commit into
Conversation
Fixes WebAssembly#1980. Add the GC top type "anyref" and "funcref" as an alias of "anyfunc". Do not add i31ref, eqref, structref, arrayref, null bottoms, or exnref. DefaultValue for anyref is val_default (ref.null any, JS null), not the externref default (undefined).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1980.
Add the GC top type
"anyref"and"funcref"as an alias of"anyfunc"to the JS API string enums. That matches the last comment on the issue. Acceptanyrefandfuncrefnow. Do not addi31ref,eqref,structref, orarrayref. Do not add null bottoms. Do not addexnref.DefaultValueforanyrefisval_default(ref.null any→ JSnull). That is not theexternrefdefault (undefined).ToWebAssemblyValueis unchanged. Ananyrefglobal can be defaulted or set tonull, an i31, or an exported GC object. A plain JS object still fails thematch_valtypecheck (host refs are extern, not any).