[js-api] Handle thenable Module in instantiate(bytes)#2118
Open
backes wants to merge 1 commit intoWebAssembly:mainfrom
Open
[js-api] Handle thenable Module in instantiate(bytes)#2118backes wants to merge 1 commit intoWebAssembly:mainfrom
backes wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
Add an explicit check in "instantiate a promise of a module" to ensure the fulfilled value of the compilation promise implements the Module interface. This prevents a modified WebAssembly.Module.prototype.then from subverting the instantiation process with a non-Module value. Also add regression tests in test/js-api/constructor/instantiate.any.js. Fixes WebAssembly#2034
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit check in "instantiate a promise of a module" to ensure the fulfilled value of the compilation promise implements the Module interface. This prevents a modified WebAssembly.Module.prototype.then from subverting the instantiation process with a non-Module value.
Also add regression tests in test/js-api/constructor/instantiate.any.js.
Fixes #2034