Fix ChildTyper on unreachable and shared ArrayCmpxchg#8797
Merged
Conversation
tlively
approved these changes
Jun 2, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Nice, my agentic fuzzer had found this bug but then totally bungled the fix and I hadn't been able to reproduce it myself.
| @@ -1250,7 +1250,11 @@ template<typename Subtype> struct ChildTyper : OverriddenVisitor<Subtype> { | |||
| note(&curr->ref, Type(*ht, Nullable)); | |||
| note(&curr->index, Type::i32); | |||
| // TODO: (shared eq) as appropriate. | |||
Comment on lines
+5
to
+6
| ;; Check that we properly validate array.atomic.rmw.cmpxchg of a shared array, | ||
| ;; when the instruction is unreachable. |
Member
There was a problem hiding this comment.
I would say "properly parse when the the expected field does not have the correct sharedness" rather than "validate," since the validator isn't involved here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.