Add missing array bounds checks in visitArrayRMW and visitArrayCmpxchg#8351
Open
sumleo wants to merge 1 commit intoWebAssembly:mainfrom
Open
Add missing array bounds checks in visitArrayRMW and visitArrayCmpxchg#8351sumleo wants to merge 1 commit intoWebAssembly:mainfrom
sumleo wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
…ayCmpxchg The interpreter's visitArrayRMW and visitArrayCmpxchg were accessing data->values[indexVal] without first checking if indexVal is within bounds. This could lead to out-of-bounds memory access when the index exceeds the array length. Add the same bounds check pattern used by visitArrayGet and visitArraySet: trap with "array oob" when indexVal >= data->values.size().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The interpreter's
visitArrayRMWandvisitArrayCmpxchginwasm-interpreter.haccessdata->values[indexVal]without verifying thatindexValis within the array's bounds. This can lead to out-of-bounds memory access when the index exceeds the array length.This PR adds the same bounds check pattern already used by
visitArrayGetandvisitArraySet:The check is added in both
visitArrayRMWandvisitArrayCmpxchg, immediately after computingindexValand before accessingdata->values[indexVal].Test plan
binaryen-unittests).visitArrayGet(line 2318) andvisitArraySet(line 2333), so it is consistent with the rest of the codebase.