Draft
Conversation
stevenfontanella
force-pushed
the
waitqueue-wait
branch
2 times, most recently
from
bd62ca8 to
a6d098e
Compare
stevenfontanella
force-pushed
the
waitqueue-wait
branch
from
a6d098e to
0979bd4
Compare
stevenfontanella
force-pushed
the
waitqueue-wait
branch
from
0979bd4 to
1dc0450
Compare
stevenfontanella
changed the title
kripken
reviewed
Feb 20, 2026
| ht = curr->structType; | ||
| } | ||
| note(&curr->ref, Type(*ht, Nullable)); | ||
| note(&curr->expected, Type(Type::BasicType::i32)); |
Member
There was a problem hiding this comment.
Comparing this to AtomicWait, I see note(&curr->expected, curr->expectedType); there. Why is it i32 here? Is the spec just very different perhaps?
Member
There was a problem hiding this comment.
AtomicWait on memory comes in i32 and i64 variants. So far we only have an i32 variant for waitqueues.
Member
Author
|
(Not 100% ready for review yet, will mark as ready for review again later) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interpreter implementation is left stubbed out and will be added in the next PR. Part of #8315.