Check isBasic() before getBasic() in validator#8157
Merged
kripken merged 3 commits intoWebAssembly:mainfrom Jan 5, 2026
Merged
Check isBasic() before getBasic() in validator#8157kripken merged 3 commits intoWebAssembly:mainfrom
kripken merged 3 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Dec 30, 2025
| const char* text, | ||
| Function* func = nullptr) { | ||
| if (!ty.isBasic()) { | ||
| fail(std::string(text) + " (not basic)", curr, func); |
Member
There was a problem hiding this comment.
I don't think it's worth adding more details to the error message here.
Member
Author
There was a problem hiding this comment.
What detail did you have in mind? Note that text already contains "should be an integer" in all callers, so this just adds a note about basicness.
Member
Author
There was a problem hiding this comment.
Oh wait, I misread your comment... reversed it, in fact 😄
I'll remove the "not basic".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids asserting.
Fixes #8097