LeetCode-2540: Minimum Common Value (3 Solution)

[WazedKhan]

Summary by CodeRabbit

Release Notes

• New Features

  • Implemented a new solution module for identifying the first common value between two sorted integer arrays, returning the match or -1 when no common element exists.

• Tests

  • Added comprehensive parametrized test suite covering multiple scenarios including arrays with duplicate values, identical arrays, and edge cases.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds a solution for LeetCode problem 2540 ("minimum common value") that identifies the first common element between two sorted integer arrays using a two-pointer scan. The solution returns -1 if no common value exists. Comprehensive parametrized tests validate the algorithm across multiple scenarios.

Changes

LeetCode Problem 2540: Minimum Common Value

Layer / File(s)	Summary
Solution implementation with two-pointer algorithm LeetCode/easy/mini_common_value_2540.py	The Solution.getCommon method advances two indices across nums1 and nums2, returning the first matching value found or -1 if no common element exists.
Test validation for minimum common value tests/test_leetcode_easy.py	Parametrized pytest test defines multiple input/output cases—including duplicates, identical arrays, and no common values—and validates that getCommon returns the correct result for each scenario.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through sorted arrays so fine,
Two pointers dance till common ground they find,
No match? Return minus one, the answer divine!
Tests pass with glee—this problem's by design. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly references LeetCode problem 2540 and mentions 'Minimum Common Value', which directly corresponds to the changeset's primary objective of adding a solution implementation and tests.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 2540-minimum-common-value

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

tests/test_leetcode_easy.py (1)

208-219: 💤 Low value

Consider adding empty array edge case to test coverage.

The test cases provide good coverage of typical scenarios. Consider adding an explicit test for empty arrays to document this edge case behavior, for example:

([], [1, 2, 3], -1),  # empty nums1
([1, 2, 3], [], -1),  # empty nums2

While the implementation handles empty arrays correctly (returning -1), having explicit test cases improves edge case documentation and confidence.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/test_leetcode_easy.py` around lines 208 - 219, Add explicit empty-array
cases to the pytest parametrization so edge behavior is documented and covered:
update the pytest.mark.parametrize entry for "nums1, nums2, expected" to include
([], [1, 2, 3], -1) and ([1, 2, 3], [], -1) alongside the existing tuples (this
targets the parametrized test block in tests/test_leetcode_easy.py).

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/test_leetcode_easy.py`:
- Around line 208-219: Add explicit empty-array cases to the pytest
parametrization so edge behavior is documented and covered: update the
pytest.mark.parametrize entry for "nums1, nums2, expected" to include ([], [1,
2, 3], -1) and ([1, 2, 3], [], -1) alongside the existing tuples (this targets
the parametrized test block in tests/test_leetcode_easy.py).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 254b9b08-a0eb-44e2-ad3d-9c826656d68d

📥 Commits

Reviewing files that changed from the base of the PR and between 9f614c0 and c5a455f.

📒 Files selected for processing (2)

• LeetCode/easy/mini_common_value_2540.py
• tests/test_leetcode_easy.py