Added options for panel/dock positions and finer autohide configuration#306
Added options for panel/dock positions and finer autohide configuration#306AKArien wants to merge 2 commits intoWayfireWM:masterfrom
Conversation
1cfce45 to
787bdaf
Compare
|
I'm interested in some of the features in this PR, is this suitable for trying out at this moment? |
|
@eaglgenes101 hi, thanks for your interest ! Exception is the "orientation" (pivoting) feature : options for rotated icons in the dock don't look and feel great, because the icons are not perfect squares and the widgets are still laid out as per their original dimensions, leading to a bit of overlap. I also meant to let panel widgets be oriented similarly, but it's even more of a problem there. |
|
In the end, I decided that this functionality isn't exactly what I wanted. That said, having icons on the side dock works well, and I don't recall any bugs I ran into. |
62f92cf to
ddac8a7
Compare
|
Probably not perfect as is, but i’m hoping it won’t be a waste of your time to review :) |
|
@trigg hey there, taking the liberty to ping you to ask how much breaking is ok. |
|
After a quick read through, this looks well thought out. As to the questions:
I've not had a chance yet to run this and see it in action, I intend to soon |
|
Just a note that i’d like to make some changes accounting for things that have been merged recently (notably, 328, 339, and 343 if it gets merged) For the deprecation, we are waiting for a wf-config mechanism, right ? Has there been discussion/decisions on how it should be done ? |
- Adjusted the naming of a few options in adequation with new features - Added options to control the delay before doing the showing/hiding animations - Added options to place the panel and dock on the left and right edges of the screen - Added minimal width option - Added option to force spanning the full edge - Option to force the panel to be centered by the middle box instead of the total width. This will lead to more spaced out elements in the side that takes less space For the panel, most widgets have a layout adaptation for the vertical panel. Exceptions are network and window-list, because i couldn’t figure out a clean or good way to do it are. Textual widgets (clock, command-output and arguably both of the previously mentionned unchanged) don’t have special adaptations, the formatting for the text they output should be adapted to account for it. Maybe it would be a good idea to add examples to the default config file/wiki. Breaking stuff : - dock/dock_height is replaced by dock/minimal_height Adresses WayfireWM#259
Now using a flowbox. Deletes the css class out_box due to deleting the widget that uses it. Doing so removes some possibilities for styling until WayfireWM#306 is merged, at which point style on out_box could be moved to wf-dock and turning on it’s new span_full_edge option.
For the panel, most widgets have a layout adaptation for the vertical panel. Exceptions are network and window-list, because i couldn’t figure out a clean or good way to do it are. Textual widgets (clock, command-output and arguably both of the previously mentionned unchanged) don’t have special adaptations, the formatting for the text they output should be adapted to account for it. Maybe it would be a good idea to add examples to the default config file/wiki.
Breaking stuff :
Adresses #259