-
-
Notifications
You must be signed in to change notification settings - Fork 506
feat(codex): allow opt-in network access for subagents #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -192,6 +192,9 @@ | |
| "effort": { | ||
| "type": "string", | ||
| "minLength": 1 | ||
| }, | ||
| "networkAccess": { | ||
| "type": "boolean" | ||
| } | ||
|
Comment on lines
+196
to
198
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The shared provider schema allows |
||
| }, | ||
| "required": [ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Reject
networkAccessfor non-Codex providers in the JSON Schema.This schema adds
networkAccessto every provider object. The Zod schema rejects the field unlessidis"codex". A JSON Schema consumer can therefore accept{ "id": "claude", "networkAccess": true }, while DevSpace later rejects it.Add a conditional or provider-specific
oneOfso both schemas enforce the same contract.🤖 Prompt for AI Agents
Source: Coding guidelines