Variational data assimilation#122
Open
SCiarella wants to merge 4 commits into
Open
Conversation
|
SarahAlidoost
approved these changes
Jun 1, 2026
Collaborator
SarahAlidoost
left a comment
There was a problem hiding this comment.
@SCiarella the notebook looks awesome 🥇 thanks! The explanations and plots are clear, I was able to run the notebook. There are some comments that should be fixed before the merge. Then we can ask others to have a look and provide feedback.
- Please add the diffwofost logo at the top, similar to other nbs
- in cell 1, in section "Variational data assimilation with diffWOFOST", where it says: "Earlier notebooks in this series demonstrated the Kalman-filter route ...", should be changed to "PCSE notebooks demonstrated the Kalman-filter route ...".
- In section "Background on data assimilation", the equation does not render correctly, please remove space after/before
$$. - In section "2.2.1 Defining the synthetic observations", the link to test data doesnot work because those test data are only available if someone runs pytest. Similar to other nbs, we should download them as:
import urllib.request
url = "https://raw.githubusercontent.com/ajwdewit/pcse/refs/heads/master/tests/test_data/test_waterlimitedproduction_wofost72_03.yaml"
filename = "test_waterlimitedproduction_wofost72_03.yaml"
urllib.request.urlretrieve(url, filename)
print(f"Downloaded: {filename}")
test_data_path = "test_waterlimitedproduction_wofost72_03.yaml"- In section "2.2.1 Defining the synthetic observations", we don't need
Truth_external_statesas wofost72 does not need external variables. - Cells number 39 and 43 are too long. Can you please break them into smaller cells where it is possible and add some inline comments.
- I like how you defined observations in "2.2.1 Defining the synthetic observations" 👍 This is something to be discussed and get feedback from research group.
- In cell 33, in
class VariationalDiffWofost72, inrun_model, whereprovider = copy.deepcopy(self.base_provider). We don't need this copy anymore right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #117 by adding a notebook dedicated to Variational data assimilation.
No new features have been added, so the changes are confined to the new notebook (+ docs)