refactor(VLE): use inject() instead of constructor#2245
Open
hirokiterashima wants to merge 56 commits intodevelopfrom
Open
refactor(VLE): use inject() instead of constructor#2245hirokiterashima wants to merge 56 commits intodevelopfrom
hirokiterashima wants to merge 56 commits intodevelopfrom
Conversation
❌ 3 blocking issues (3 total)
|
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (303) Showing 100 of 303 files. See full report for all files. 🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
…AdvancedComponentComponent
…sroomMonitorComponents/shared
…omMonitorComponents
~ Conflicts: ~ src/app/notebook/notebook-launcher/notebook-launcher.component.ts ~ src/app/notebook/notebook-notes/notebook-notes.component.ts ~ src/app/notebook/notebook-report/notebook-report.component.ts ~ src/assets/wise5/authoringTool/components/component-authoring.component.ts ~ src/assets/wise5/services/projectTranslationService.ts ~ src/assets/wise5/services/studentProjectTranslationService.ts ~ src/assets/wise5/themes/default/themeComponents/stepTools/step-tools.component.ts ~ src/messages.xlf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
EditBranchService)
Test