Skip to content

fix process stdio when frozen as gui a executable#129

Merged
Vizonex merged 1 commit intomainfrom
freezed-gui-fix
Apr 9, 2026
Merged

fix process stdio when frozen as gui a executable#129
Vizonex merged 1 commit intomainfrom
freezed-gui-fix

Conversation

@Vizonex
Copy link
Copy Markdown
Owner

@Vizonex Vizonex commented Apr 9, 2026

What do these changes do?

This change makes it so that tools like CX_Freeze can properly execute subprocesses in relation to bug #126

Are there changes in behavior for the user?

Problem solved. I just wanted to fix a couple of the last few bugs before we decomission winloop in the future and merge it to uvloop. Glad we fixed this though without screwing up more code in the process. We might need a way to close the handle when were done with it but I was able to reduce it to only leaking one handle if this is the case. Feel free to come up with a smarter PR for doing this that doesn't leak any handles. If winloop is decomissioned before then make the PR to uvloop and I will be there to help with the reviewing process.

Is it a substantial burden for the maintainers to support this?

Nope, uvloop contributors should be capable of understanding why this is here.

Related issue number

fixes #126

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Vizonex
Copy link
Copy Markdown
Owner Author

Vizonex commented Apr 9, 2026

@XiaoYouChR I hope this is what you expected. It may not be smart for me not to implement a CloseHandle but doing so just crashes the program hopefully someone smarter comes along to either winloop or uvloop later on and finds a smarter method for now I can finally rest. I might need someone to come up with a test but other than that, this case is successfully closed.

@Vizonex Vizonex merged commit 5a35708 into main Apr 9, 2026
22 of 24 checks passed
@Vizonex Vizonex deleted the freezed-gui-fix branch April 9, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows + cx_Freeze GUI build: create_subprocess_exec() fails with OSError [Errno 9] bad file descriptor unless stdin=DEVNULL

1 participant