fix process stdio when frozen as gui a executable#129
Merged
Conversation
Owner
Author
|
@XiaoYouChR I hope this is what you expected. It may not be smart for me not to implement a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change makes it so that tools like CX_Freeze can properly execute subprocesses in relation to bug #126
Are there changes in behavior for the user?
Problem solved. I just wanted to fix a couple of the last few bugs before we decomission winloop in the future and merge it to uvloop. Glad we fixed this though without screwing up more code in the process. We might need a way to close the handle when were done with it but I was able to reduce it to only leaking one handle if this is the case. Feel free to come up with a smarter PR for doing this that doesn't leak any handles. If winloop is decomissioned before then make the PR to uvloop and I will be there to help with the reviewing process.
Is it a substantial burden for the maintainers to support this?
Nope, uvloop contributors should be capable of understanding why this is here.
Related issue number
fixes #126
Checklist