Fix icon migration, cookie-policy i18n, and credential wizard step 4#2
Merged
Conversation
FaIcon was removed from ease-bootstrap5-widgets in its Bootstrap 5 upgrade (replaced by BsIcon), so these pages fatal-errored with "Class Ease\TWB5\Widgets\FaIcon not found". Switch to BsIcon and map the FontAwesome icon names to Bootstrap Icons equivalents; convert fa-2x sizing to the Bootstrap fs-1 utility. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fill in the 48 untranslated cookie-policy.php strings in the cs_CZ catalogue and recompile the .mo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Set version=0 when creating a new credential type (NOT NULL column with no default caused a PDOException). - Carry hint and defval when copying prototype fields to the new type. - Create the credential via Credential::takeData()/dbsync() (the proven path) instead of the non-existent CredentialConfigFields write API. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related fixes found while going through the GDPR/credential UI.
1. Migrate remaining
FaIconusages toBsIconFaIconwas removed fromease-bootstrap5-widgets(replaced byBsIcon), so several pages fatal-errored with ClassEase\TWB5\Widgets\FaIconnot found. Switched toBsIcon, mapped FontAwesome names to Bootstrap Icons, and convertedfa-2xsizing to the Bootstrapfs-1utility.Files:
DataExportWidget.php,admin-deletion-requests.php,consent-preferences.php,data-export-page.php.2. Czech translations for the cookie policy page
Filled the 48 untranslated
cookie-policy.phpstrings in thecs_CZcatalogue and recompiled the.mo. Verified live with?locale=cs_CZ— no English left.3. Credential wizard step 4
version = 0when creating a new credential type (NOT NULL column with no default →PDOException).hint/defvalwhen copying prototype fields to the new type.Credential::takeData()/dbsync()(the proven path) instead of the non-existentCredentialConfigFieldswrite API.Verified by driving the whole wizard end-to-end (incl. a prototype with fields) — credential is created and the page redirects correctly.
🤖 Generated with Claude Code