Upgrade to PHP 8 and refactor to PSR Interfaces#59
Open
janolivermr wants to merge 6 commits intoVisualAppeal:mainfrom
Open
Upgrade to PHP 8 and refactor to PSR Interfaces#59janolivermr wants to merge 6 commits intoVisualAppeal:mainfrom
janolivermr wants to merge 6 commits intoVisualAppeal:mainfrom
Conversation
This also adds types to all properties and functions
Also add .idea folder to gitignore
Member
|
Thank you very much! Will check out the changes later today, merge them and create a new major version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to abandon #58 in favour of one PR for all changes since some of them are linked with PHP 8 null-safe operator.
This change removes the dependency on both
desarrolla2/cacheandmonolog/monologand depends on the PSR interfaces instead.It also bumps the PHP version up to 8.0 and adds types to the properties, as well as function return types.