Repository navigation
Conversation
Add opt-in skipMergedCells shadow configuration for cross-boundary merges. Preserve the default rectangle renderer, shadow styling and visibility. Include unit coverage, an interactive visual case, an example and bilingual docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
No existing issue linked.
💡 Background and solution
A merged summary row spanning frozen and scrolling columns is visually interrupted by the frozen-column shadow. Add the opt-in
theme.frozenColumnLine.shadow.skipMergedCellsoption so the summary remains visually continuous.When enabled, subtract cross-boundary merged-cell intervals from the left and right frozen shadow paths. This supports multiple gaps, merges spanning multiple rows, and top/bottom frozen rows, and follows scrolling, geometry changes and theme updates. Ordinary rows retain the existing shadow width, colors and visibility modes.
The option defaults to
false, which keeps the original rectangle renderer. Includes bilingual option documentation, a development example, a Rush minor change file, 11 unit tests and a visual case with real toggle and scroll interactions.The screenshot shows two middle merges and a bottom summary spanning the freeze boundaries, with the default shadow style:
Validation
node packages/vtable/scripts/visual-test.mjscommand was executed against official develop5c9451acfc70829241e223fc772b966756d3f70c. Its native status is error, solely because the newfrozen-shadow-merged-cellscase asserts the new API, which the old official baseline does not implement. The runner therefore does not enter the current phase. The 204 existing official-baseline screenshots were compared separately against the full current-run screenshots as described above. Self-comparison is not reported as official-baseline success; no assertion was skipped or threshold relaxed.20035e537462b9a3507c7e0a4a902c8b4cb66b05.📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough